[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Initial Submission - Final Edition for review



Hi Carol,

 > Please review for accuracy... if I have stuff plain wrong this is more
 > important than any formatting or simple typo stuff at this point.  I found
 > a LOT of left-overs from earlier names of interfaces, methods, and types in
 > the text, but I may not have caught everything.

Finally, I took a moment. Here are some comments, hopefully not too
late.

Bart.
________________________________________________________________________________

Minor:

IDL: (p. 27, 30, 46):
  The multiple_access_allowed method takes an AccessDefinitionList as
  first argument, while for access_allowed the AccessDefinition is
  taken apart. I'd suggest to change access_allowed as follows:

	boolean access_allowed(
		in AccessDefinition access_request,
		in AttributeList    attribute_list
	);

  That makes it more consistent with multiple_access_allowed and
  guards against any changes in the structure of AccessDefinition.


p. 29:
  There are methods to set, replace and add evaluators.
  How about one to get or list them:

	PolicyEvaluatorList get_evaluators(
		in ResourceName
	);



Editorial:

p. 10: ... the submission team believes does not believe ...
I believe that should be : ... the submission team does not believe...

p. 10: This discussion will be provided
                            ^^

p. 25: (near bottom) ... modified or controlled by the HRAC.
                                            ^^

-- 
+-------------------------------------------------------------------+
| Bart L. de Greef                      Philips Medical Systems     |
| degreef@medgrid.philips.com           Sr. Member Technical Staff  |
| Phone     : +1 650 426 2557           Fax : +1 650 426 2550       |
| Snail mail: Philips Medical Systems,                              |
|             2171 Landings Drive, Mountain View CA 94043-0837, USA |
+-------------------------------------------------------------------+
    "Experience is the name everyone gives to their mistakes."
----------------
Broadcast message to hrac-rfp from Bart de Greef <degreef@medgrid.philips.com>.
Go to http://cadse.cs.fiu.edu/omg/hrac-rfp to browse the mail list archive.